-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time between heartbeats at bootstrap #4897
Conversation
@@ -917,6 +917,7 @@ | |||
PeerAuthenticationTimeBetweenSendsWhenErrorInSec = 60 # 1min | |||
PeerAuthenticationThresholdBetweenSends = 0.1 # 10% | |||
HeartbeatTimeBetweenSendsInSec = 60 # 1min | |||
HeartbeatTimeBetweenSendsDuringBootstrapInSec = 60 # 1min |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to have this set to 1 minute on the public testnets & mainnet? The original code used HeartbeatTimeBetweenSendsInSec
which was set to 5 minutes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly, this was the reason behind the PR. While testing on public testnet, I realized that 5 min with no feedback would be too much
Reasoning behind the pull request
Proposed changes
Testing procedure
heartbeat message sent
to be ~1 min, either check https://testnet-gateway.multiversx.com/node/heartbeatstatus and make sure thenumTrieNodesReceived
for your node increases each ~minute during trie syncnumTrieNodesReceived
0Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?