Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug logs for leader fees #4932

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Conversation

AdoAdoAdo
Copy link
Contributor

Reasoning behind the pull request

  • analysis of leader fees and rewards dust

Proposed changes

  • add some debug logs for the leader accumulated fees

Testing procedure

  • run a system test with transactions for metachain and analyse the logs

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@raduchis raduchis self-requested a review January 31, 2023 09:49
@codecov-commenter
Copy link

Codecov Report

Base: 70.80% // Head: 70.79% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2f32d8b) compared to base (aa657cb).
Patch coverage: 65.21% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.4.0    #4932      +/-   ##
=============================================
- Coverage      70.80%   70.79%   -0.01%     
=============================================
  Files            648      648              
  Lines          85262    85284      +22     
=============================================
+ Hits           60366    60375       +9     
- Misses         20366    20378      +12     
- Partials        4530     4531       +1     
Impacted Files Coverage Δ
process/block/metablock.go 61.98% <50.00%> (-0.09%) ⬇️
process/peer/process.go 72.80% <100.00%> (+0.27%) ⬆️
consensus/broadcast/delayedBroadcast.go 84.81% <0.00%> (-1.41%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iulianpascalau iulianpascalau merged commit b1de069 into rc/v1.4.0 Feb 1, 2023
@iulianpascalau iulianpascalau deleted the accumulated-fees-logs branch February 1, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants