Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused IsTransferToMetaFlagEnabled #4989

Merged
merged 2 commits into from Feb 15, 2023

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Feb 15, 2023

Reasoning behind the pull request

  • Obsolete IsTransferToMetaFlagEnabled flag was removed from mx-chain-go and vm-common as well.

Proposed changes

  • Remove IsTransferToMetaFlagEnabled from project

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic self-assigned this Feb 15, 2023
@mariusmihaic mariusmihaic marked this pull request as ready for review February 15, 2023 10:20
Base automatically changed from MX-13669-stakingv4-epochs-protection to feat/staking-v4 February 15, 2023 11:58
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feat/staking-v4@25994dd). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 73e90b8 differs from pull request most recent head b2c377a. Consider uploading reports for the commit b2c377a to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@                Coverage Diff                 @@
##             feat/staking-v4    #4989   +/-   ##
==================================================
  Coverage                   ?   70.91%           
==================================================
  Files                      ?      663           
  Lines                      ?    86527           
  Branches                   ?        0           
==================================================
  Hits                       ?    61358           
  Misses                     ?    20622           
  Partials                   ?     4547           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mariusmihaic mariusmihaic merged commit fb4ad8c into feat/staking-v4 Feb 15, 2023
@mariusmihaic mariusmihaic deleted the MX-13829-stakingv4-new-vm-common branch February 15, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants