Fixed self-blacklisted event in consensus due to edge case when setting the epoch as proposer #5006
Conversation
…ting the current epoch
iulianpascalau
added
type:bug
| if initialHdr.GetEpoch() != epoch { | ||
| log.Debug("shardProcessor.CreateBlock: epoch from header is not the same as epoch from epoch start trigger, overwriting", | ||
| "epoch from header", initialHdr.GetEpoch(), "epoch from epoch start trigger", epoch) | ||
| err = shardHdr.SetEpoch(epoch) |
There was a problem hiding this comment.
System test passed .
@@ Log scanner @@
fix-shard-header-construction-epoch
================================================================================
- Known Warnings 12
- New Warnings 5
- Known Errors 0
- New Errors 0
- Panics 0
================================================================================ - block hash does not match 23649
- miniblocks does not match 0
- miniblock hash does not match 0
- receipts hash missmatch 0
- wrong nonce in block 7315
================================================================================ - No jailed nodes on the thestnet
================================================================================
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5006 +/- ##
============================================
Coverage ? 70.66%
============================================
Files ? 666
Lines ? 86523
Branches ? 0
============================================
Hits ? 61140
Misses ? 20791
Partials ? 4592 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Reasoning behind the pull request
CreateNewHeaderthe leader might get the new epoch start metablock in an async matter, thus incorrectly setting theEpochStartMetaHashvalue inCreateBlockfunction but on the previous epochProposed changes
Testing procedure
shardProcessor.CreateBlock: epoch from the header is not the same as epoch from epoch start trigger, overwritingPre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?