Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value as string on response for /transaction/pool by sender #5012

Merged
merged 3 commits into from Feb 23, 2023

Conversation

sstanculeanu
Copy link
Contributor

Reasoning behind the pull request

  • invalid value returned
    image

Proposed changes

  • use value as string

Testing procedure

  • standard system test with some txs in pool and call /transaction/pool?by-sender=erd1...&fields=value and make sure value is a valid string, not as in the above picture

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu self-assigned this Feb 21, 2023
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed .

@@ Log scanner @@

fix_value_on_transaction_pool_route

================================================================================

  • Known Warnings 7
  • New Warnings 1
  • Known Errors 0
  • New Errors 1
  • Panics 0
    ================================================================================
  • block hash does not match 1726
  • miniblocks does not match 0
  • miniblock hash does not match 0
  • receipts hash missmatch 0
  • wrong nonce in block 781
    ================================================================================
  • No jailed nodes on the thestnet
    ================================================================================

@sstanculeanu sstanculeanu merged commit d0b7a43 into rc/v1.6.0 Feb 23, 2023
@sstanculeanu sstanculeanu deleted the fix_value_on_transaction_pool_route branch February 23, 2023 17:19
@sstanculeanu sstanculeanu added type:bug Something isn't working area:node-api Node API labels Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:node-api Node API type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants