Fix import db on rc v1.6.0 #5018
Conversation
iulianpascalau
added
type:bug
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5018 +/- ##
============================================
Coverage ? 70.64%
============================================
Files ? 666
Lines ? 86516
Branches ? 0
============================================
Hits ? 61119
Misses ? 20812
Partials ? 4585 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dataRetriever/common_test.go
Outdated
| } | ||
|
|
||
| func TestSetEpochHandlerToHdrResolver_CannotSetEpoch(t *testing.T) { | ||
| func TestSetEpochHandlerToHdrRequester_GetErr(t *testing.T) { |
There was a problem hiding this comment.
| func TestSetEpochHandlerToHdrRequester_GetErr(t *testing.T) { | |
| func TestSetEpochHandlerToHdrRequester(t *testing.T) { |
same for TestSetEpochHandlerToHdrResolver_GetErr
| ) | ||
|
|
||
| // RequestersContainerStub - | ||
| type RequestersContainerStub struct { |
There was a problem hiding this comment.
why not use the one from testscommon/dataRetriever ? common_test.go is part of dataRetriever_test package so there should be no cyclic dependency
dataRetriever/common_test.go
Outdated
| t.Run("get function errors should return error", func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| localErr := errors.New("err") |
There was a problem hiding this comment.
can be extracted as global
There was a problem hiding this comment.
System test passed.
@@ Log scanner @@
fix-import-db-on-rc-v1.6.0
================================================================================
- Known Warnings 8
- New Warnings 2
- Known Errors 0
- New Errors 1
- Panics 0
================================================================================ - block hash does not match 1951
- miniblocks does not match 0
- miniblock hash does not match 0
- receipts hash missmatch 0
- wrong nonce in block 698
================================================================================ - No jailed nodes on the thestnet
================================================================================
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?