extracted configuration value for vm-queries delay #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
added
area:node-api
mariusmihaic
reviewed
Mar 9, 2023
| @@ -516,9 +516,13 @@ func (nr *nodeRunner) executeOneComponentCreationCycle( | |||
|
|
|||
| log.Info("application is now running") | |||
|
|
|||
| delayInSecBeforeAllowingVmQueries := configs.GeneralConfig.WebServerAntiflood.VmQueryDelayAfterStartInSec | |||
| if delayInSecBeforeAllowingVmQueries == 0 { | |||
There was a problem hiding this comment.
Shall we add a warn here to specify that we override the config value?
cmd/node/config/config.toml
Outdated
| @@ -589,6 +589,8 @@ | |||
| TrieOperationsDeadlineMilliseconds = 10000 | |||
| # GetAddressesBulkMaxSize represents the maximum number of addresses to be fetched in a bulk per API request. 0 means unlimited | |||
| GetAddressesBulkMaxSize = 100 | |||
| # VmQueryDelayAfterStartInSec represents the number of seconds to wait when starting node before accepting vm query requests | |||
| VmQueryDelayAfterStartInSec = 5 | |||
There was a problem hiding this comment.
Isn't 5 sec even for testnets too low for a value?
There was a problem hiding this comment.
used this for testing, forgot to change back. done
sstanculeanu
approved these changes
Mar 9, 2023
mariusmihaic
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
VmQueryDelayAfterStartInSecvalue and (re)start a node. after the number of seconds specified in the config, it should accept API VM Queries. Query example:Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?