Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic displayer integration tests #5093

Merged
merged 2 commits into from Mar 21, 2023

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Mar 14, 2023

Reasoning behind the pull request

  • StakingV4 integration tests have a "displayer" component which prints the node configuration at every committed block, which is very useful for easy debugging. However, since iteration was done on maps, the shardIDs order and pubkeys order was not determistic, making it a bit difficult to follow node changes during an epoch/block

Proposed changes

  • Sorted nodes inside shards and nodes list for a deterministic output

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic changed the title FEAT: Deterministic displayer Deterministic displayer Mar 14, 2023
@mariusmihaic mariusmihaic changed the title Deterministic displayer Deterministic displayer integration tests Mar 14, 2023
@mariusmihaic mariusmihaic self-assigned this Mar 14, 2023
@mariusmihaic mariusmihaic marked this pull request as ready for review March 14, 2023 10:08
Base automatically changed from MX-13949-config-protection-num-nodes to feat/staking-v4 March 21, 2023 09:00
@mariusmihaic mariusmihaic merged commit c58cb01 into feat/staking-v4 Mar 21, 2023
3 checks passed
@mariusmihaic mariusmihaic deleted the MX-13934-deterministic-displayer2 branch March 21, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants