Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New peers rating handler implementation #5099

Merged
merged 9 commits into from Mar 16, 2023

Conversation

sstanculeanu
Copy link
Contributor

@sstanculeanu sstanculeanu commented Mar 14, 2023

Reasoning behind the pull request

  • new peers rating handler implementation added

Proposed changes

  • updated mx-chain-p2p-go to have the latest peers ratings handler and integrated it

Testing procedure

  • will be tested with the full feat branch

Example response to new route:
image

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu self-assigned this Mar 14, 2023
@sstanculeanu sstanculeanu marked this pull request as draft March 14, 2023 17:15
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Patch coverage: 84.37% and project coverage change: -0.17 ⚠️

Comparison is base (834c36f) 70.79% compared to head (f68e00c) 70.63%.

❗ Current head f68e00c differs from pull request most recent head 0687f82. Consider uploading reports for the commit 0687f82 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@                        Coverage Diff                        @@
##           feat/fix-peers-rating-handler    #5099      +/-   ##
=================================================================
- Coverage                          70.79%   70.63%   -0.17%     
=================================================================
  Files                                659      666       +7     
  Lines                              85633    86620     +987     
=================================================================
+ Hits                               60628    61184     +556     
- Misses                             20440    20839     +399     
- Partials                            4565     4597      +32     
Impacted Files Coverage Δ
api/gin/common.go 30.95% <ø> (ø)
api/gin/httpServer.go 23.80% <ø> (ø)
api/gin/webServer.go 0.00% <ø> (ø)
api/gin/writers.go 0.00% <ø> (ø)
api/groups/addressGroup.go 72.02% <ø> (ø)
api/groups/addressGroupOptions.go 84.61% <ø> (ø)
api/groups/baseGroup.go 79.48% <ø> (ø)
api/groups/blockGroup.go 74.67% <ø> (ø)
api/groups/hardforkGroup.go 81.25% <ø> (ø)
api/groups/internalGroup.go 83.44% <ø> (ø)
... and 90 more

... and 72 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sstanculeanu sstanculeanu marked this pull request as ready for review March 14, 2023 18:45
@ssd04 ssd04 self-requested a review March 15, 2023 07:17
p2p/interface.go Outdated Show resolved Hide resolved
node/node.go Outdated Show resolved Hide resolved
@iulianpascalau iulianpascalau self-requested a review March 16, 2023 09:55
@@ -487,9 +487,6 @@
[PeersRatingConfig]
TopRatedCacheCapacity = 5000
BadRatedCacheCapacity = 5000
TimeWaitingForReconnectionInSec = 300 # 5 min
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sstanculeanu sstanculeanu merged commit 0c36be9 into feat/fix-peers-rating-handler Mar 16, 2023
3 checks passed
@sstanculeanu sstanculeanu deleted the new_peers_rating_handler branch March 16, 2023 10:00
@sstanculeanu sstanculeanu changed the title New peers rating handler New peers rating handler implementation Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants