Coverage for: factory/heartbeat, factory/network, factory/state #5152
Conversation
sstanculeanu
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5152 +/- ##
=============================================
+ Coverage 77.75% 78.08% +0.33%
=============================================
Files 680 680
Lines 88348 88360 +12
=============================================
+ Hits 68694 68997 +303
+ Misses 14313 14085 -228
+ Partials 5341 5278 -63
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| if check.IfNil(args.StorageService) { | ||
| return nil, errors.ErrNilStorageService | ||
| } | ||
| if check.IfNil(args.ChainHandler) { |
There was a problem hiding this comment.
Not needed to check for nil ChainHandler?
There was a problem hiding this comment.
only kept checks on the components that are used inside the factory and removed the ones that are only forwarded to subcomponents(which should do their checks on the received params)
example:
- chainHandler is saved internally only to be forwarded
- core components is saved to forward subcomponents, which requires the check
| if check.IfNil(args.StatusCoreComponents) { | ||
| return errors.ErrNilStatusCoreComponents | ||
| } | ||
| if check.IfNil(args.StatusCoreComponents.AppStatusHandler()) { |
There was a problem hiding this comment.
Not needed to check for nil AppStatusHandler and HardforkTrigger ?
There was a problem hiding this comment.
same as above, not used inside the heartbeatV2Components, only forwarded
| coreCompStub.InternalMarshalizerCalled = func() marshal.Marshalizer { | ||
| return nil |
There was a problem hiding this comment.
so this will make CreateTriesComponentsForShardId fail?
There was a problem hiding this comment.
yes CreateTriesComponentsForShardId passes the marshaller on NewTrieFactory which will eventually fail
| t.Run("nil EpochStartTrigger should error", func(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
this inner test looks to be duplicated
There was a problem hiding this comment.
indeed, removed one
There was a problem hiding this comment.
System test passed
@@ Log scanner @@
more_factory_tests_p2
================================================================================
- Known Warnings 9
- New Warnings 2
- Known Errors 0
- New Errors 0
- Panics 0
================================================================================ - block hash does not match 8444
- wrong nonce in block 3410
- miniblocks does not match 0
- num miniblocks does not match 0
- miniblock hash does not match 0
- block bodies does not match 0
- receipts hash missmatch 0
================================================================================ - No jailed nodes on the testnet
================================================================================
sstanculeanu
dismissed stale reviews from gabi-vuls and ssd04
The base branch was changed.
sstanculeanu
changed the title
…into more_factory_tests_p2 # Conflicts: # factory/heartbeat/heartbeatV2Components_test.go
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?