Fix seldom failing tests in hb v2

[iulianpascalau]

Reasoning behind the pull request

• some unit tests for the peerAuthenticationRequestsProcessor component were seldom failing

Proposed changes

• added new unit tests
• reworked tests that tested logic to work on a component that did not launched go routines
• minor production code refactoring

Testing procedure

• standard system test
• when analyzing the logs, we should find prints like:

received enough messages, closing peerAuthenticationRequestsProcessor go routine

or

closing peerAuthenticationRequestsProcessor...
closing peerAuthenticationRequestsProcessor go routine

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

• was the PR targeted to the correct branch?
• if this is a larger feature that probably needs more than one PR, is there a feat branch created?
• if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (723c557) 79.01% compared to head (50872b7) 78.98%.

❗ Current head 50872b7 differs from pull request most recent head 050d918. Consider uploading reports for the commit 050d918 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##           rc/v1.6.0    #5205      +/-   ##
=============================================
- Coverage      79.01%   78.98%   -0.04%     
=============================================
  Files            680      680              
  Lines          88018    88023       +5     
=============================================
- Hits           69550    69526      -24     
- Misses         13259    13290      +31     
+ Partials        5209     5207       -2     

Impacted Files	Coverage Δ
...t/processor/peerAuthenticationRequestsProcessor.go	95.04% <100.00%> (+0.21%)	⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[gabi-vuls]

System test passed.
@@ Log scanner @@

fix-seldom-failing-tests-in-hb-v2

================================================================================

• Known Warnings 18
• New Warnings 9
• Known Errors 0
• New Errors 2
• Panics 0
  ================================================================================
• block hash does not match 42204
• wrong nonce in block 14262
• miniblocks does not match 0
• num miniblocks does not match 0
• miniblock hash does not match 0
• block bodies does not match 0
• receipts hash missmatch 0
  ================================================================================