Coverage for: dataRetriever #5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5213 +/- ##
=============================================
+ Coverage 79.41% 79.79% +0.37%
=============================================
Files 691 691
Lines 89197 89197
=============================================
+ Hits 70836 71171 +335
+ Misses 13165 12894 -271
+ Partials 5196 5132 -64
☔ View full report in Codecov by Sentry. |
| @@ -81,3 +82,14 @@ func TestBlockChain_SettersAndGettersNilValues(t *testing.T) { | |||
| assert.Nil(t, bc.GetCurrentBlockHeader()) | |||
| assert.Empty(t, bc.GetCurrentBlockRootHash()) | |||
| } | |||
|
|
|||
| func TestBlockChain_SettersInvalidValues(t *testing.T) { | |||
| @@ -81,6 +82,7 @@ func testRequestDataFromHashArray(t *testing.T, requesterType requestHandlerType | |||
| t.Run("should work", func(t *testing.T) { | |||
| t.Parallel() | |||
|
|
|||
| _ = logger.SetLogLevel("*:TRACE") // coverage | |||
| @@ -308,3 +312,50 @@ func TestShardedData_SearchFirstDataFoundShouldRetResults(t *testing.T) { | |||
| } | |||
|
|
|||
| // TODO: Add high load test, reach maximum capacity and inspect RAM usage. EN-6735. | |||
There was a problem hiding this comment.
TODO still relevant? cc @andreibancioiu
There was a problem hiding this comment.
Not relevant anymore. The "memory tests" partially serve this TODO.
TODO can be removed.
iulianpascalau
previously approved these changes
May 4, 2023
There was a problem hiding this comment.
typos on the following lines:
- dataRetriever/factory/containers/resolversContainer_test.go:295
- dataRetriever/factory/containers/resolversContainer_test.go:272
- dataRetriever/factory/containers/resolversContainer_test.go:254
- dataRetriever/shardedData/shardedData_test.go:231
- dataRetriever/shardedData/shardedData_test.go:81
- dataRetriever/resolvers/validatorInfoResolver_test.go:382
- dataRetriever/interface.go:319
- dataRetriever/topicSender/diffPeerListCreator_test.go:78
- dataRetriever/factory/epochProviders/currentEpochProvidersFactory_test.go:28
- dataRetriever/mock/marshalizerMock.go:35
| err := hdReq.RequestDataFromEpoch(epochIdentifier) | ||
| assert.Equal(t, core.ErrInvalidIdentifierForEpochStartBlockRequest, err) | ||
| }) | ||
| t.Run("identifier not found should error should error", func(t *testing.T) { |
There was a problem hiding this comment.
"should error should error"
bogdan-rosianu
previously approved these changes
May 9, 2023
iulianpascalau
previously approved these changes
May 9, 2023
…into dataretriever_tests # Conflicts: # testscommon/storageManager/storageManagerStub.go
sstanculeanu
dismissed stale reviews from bogdan-rosianu and iulianpascalau
via
0a981e6
ssd04
approved these changes
May 26, 2023
iulianpascalau
approved these changes
May 26, 2023
bogdan-rosianu
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?