Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage for facade #5237

Merged
merged 3 commits into from
May 16, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
96 changes: 92 additions & 4 deletions facade/initial/initialNodeFacade_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"fmt"
"testing"

"github.com/multiversx/mx-chain-core-go/core/check"
"github.com/multiversx/mx-chain-core-go/data/api"
"github.com/multiversx/mx-chain-go/facade"
"github.com/multiversx/mx-chain-go/node/external"
Expand All @@ -20,14 +19,14 @@ func TestInitialNodeFacade(t *testing.T) {

inf, err := NewInitialNodeFacade("127.0.0.1:8080", true, nil)
assert.Equal(t, facade.ErrNilStatusMetrics, err)
assert.True(t, check.IfNil(inf))
assert.Nil(t, inf)
})
t.Run("should work", func(t *testing.T) {
t.Parallel()

inf, err := NewInitialNodeFacade("127.0.0.1:8080", true, &testscommon.StatusMetricsStub{})
assert.Nil(t, err)
assert.False(t, check.IfNil(inf))
assert.NotNil(t, inf)
})
}

Expand Down Expand Up @@ -233,5 +232,94 @@ func TestInitialNodeFacade_AllMethodsShouldNotPanic(t *testing.T) {
assert.Equal(t, api.GuardianData{}, guardianData)
assert.Equal(t, errNodeStarting, err)

assert.False(t, check.IfNil(inf))
mainTrieResponse, dataTrieResponse, err := inf.GetProofDataTrie("", "", "")
assert.Nil(t, mainTrieResponse)
assert.Nil(t, dataTrieResponse)
assert.Equal(t, errNodeStarting, err)

codeHash, blockInfo, err := inf.GetCodeHash("", api.AccountQueryOptions{})
assert.Nil(t, codeHash)
assert.Equal(t, api.BlockInfo{}, blockInfo)
assert.Equal(t, errNodeStarting, err)

accountsResponse, blockInfo, err := inf.GetAccounts([]string{}, api.AccountQueryOptions{})
assert.Nil(t, accountsResponse)
assert.Equal(t, api.BlockInfo{}, blockInfo)
assert.Equal(t, errNodeStarting, err)

stakeValue, err := inf.GetTotalStakedValue()
assert.Nil(t, stakeValue)
assert.Equal(t, errNodeStarting, err)

ratings := inf.GetConnectedPeersRatings()
assert.Equal(t, "", ratings)

epochStartData, err := inf.GetEpochStartDataAPI(0)
assert.Nil(t, epochStartData)
assert.Equal(t, errNodeStarting, err)

alteredAcc, err := inf.GetAlteredAccountsForBlock(api.GetAlteredAccountsForBlockOptions{})
assert.Nil(t, alteredAcc)
assert.Equal(t, errNodeStarting, err)

block, err := inf.GetInternalMetaBlockByHash(0, "")
assert.Nil(t, block)
assert.Equal(t, errNodeStarting, err)

block, err = inf.GetInternalMetaBlockByNonce(0, 0)
assert.Nil(t, block)
assert.Equal(t, errNodeStarting, err)

block, err = inf.GetInternalMetaBlockByRound(0, 0)
assert.Nil(t, block)
assert.Equal(t, errNodeStarting, err)

block, err = inf.GetInternalStartOfEpochMetaBlock(0, 0)
assert.Nil(t, block)
assert.Equal(t, errNodeStarting, err)

validatorsInfo, err := inf.GetInternalStartOfEpochValidatorsInfo(0)
assert.Nil(t, validatorsInfo)
assert.Equal(t, errNodeStarting, err)

block, err = inf.GetInternalShardBlockByHash(0, "")
assert.Nil(t, block)
assert.Equal(t, errNodeStarting, err)

block, err = inf.GetInternalShardBlockByNonce(0, 0)
assert.Nil(t, block)
assert.Equal(t, errNodeStarting, err)

block, err = inf.GetInternalShardBlockByRound(0, 0)
assert.Nil(t, block)
assert.Equal(t, errNodeStarting, err)

block, err = inf.GetInternalMiniBlockByHash(0, "", 0)
assert.Nil(t, block)
assert.Equal(t, errNodeStarting, err)

esdtData, blockInfo, err := inf.GetESDTData("", "", 0, api.AccountQueryOptions{})
assert.Nil(t, esdtData)
assert.Equal(t, api.BlockInfo{}, blockInfo)
assert.Equal(t, errNodeStarting, err)

genesisBalances, err := inf.GetGenesisBalances()
assert.Nil(t, genesisBalances)
assert.Equal(t, errNodeStarting, err)

txPoolGaps, err := inf.GetTransactionsPoolNonceGapsForSender("")
assert.Nil(t, txPoolGaps)
assert.Equal(t, errNodeStarting, err)

assert.NotNil(t, inf)
}

func TestInitialNodeFacade_IsInterfaceNil(t *testing.T) {
t.Parallel()

var inf *initialNodeFacade
assert.True(t, inf.IsInterfaceNil())

inf, _ = NewInitialNodeFacade("127.0.0.1:7799", true, &testscommon.StatusMetricsStub{})
assert.False(t, inf.IsInterfaceNil())
}
6 changes: 5 additions & 1 deletion facade/mock/nodeStub.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ type NodeStub struct {
GetProofCalled func(rootHash string, key string) (*common.GetProofResponse, error)
GetProofDataTrieCalled func(rootHash string, address string, key string) (*common.GetProofResponse, *common.GetProofResponse, error)
VerifyProofCalled func(rootHash string, address string, proof [][]byte) (bool, error)
GetTokenSupplyCalled func(token string) (*api.ESDTSupply, error)
}

// GetProof -
Expand Down Expand Up @@ -268,7 +269,10 @@ func (ns *NodeStub) GetAllESDTTokens(address string, options api.AccountQueryOpt
}

// GetTokenSupply -
func (ns *NodeStub) GetTokenSupply(_ string) (*api.ESDTSupply, error) {
func (ns *NodeStub) GetTokenSupply(token string) (*api.ESDTSupply, error) {
if ns.GetTokenSupplyCalled != nil {
return ns.GetTokenSupplyCalled(token)
}
return nil, nil
}

Expand Down