Mx 13962 consistent tokens values length checks #5245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5245 +/- ##
=============================================
- Coverage 79.41% 79.41% -0.01%
=============================================
Files 691 691
Lines 89193 89197 +4
=============================================
+ Hits 70837 70839 +2
- Misses 13161 13162 +1
- Partials 5195 5196 +1
☔ View full report in Codecov by Sentry. |
sasurobert
reviewed
May 18, 2023
go.mod
Outdated
| @@ -19,7 +19,7 @@ require ( | |||
| github.com/multiversx/mx-chain-logger-go v1.0.11 | |||
| github.com/multiversx/mx-chain-p2p-go v1.0.16 | |||
| github.com/multiversx/mx-chain-storage-go v1.0.8 | |||
| github.com/multiversx/mx-chain-vm-common-go v1.4.1 | |||
| github.com/multiversx/mx-chain-vm-common-go v1.4.2-0.20230515133310-3417cce7427e | |||
…h-checks # Conflicts: # common/enablers/enableEpochsHandler.go # common/enablers/epochFlags.go # common/interface.go # config/tomlConfig_test.go # go.mod # go.sum # sharding/mock/enableEpochsHandlerMock.go # testscommon/enableEpochsHandlerStub.go
config/tomlConfig_test.go
Outdated
| @@ -799,6 +802,7 @@ func TestEnableEpochConfig(t *testing.T) { | |||
| SetGuardianEnableEpoch: 64, | |||
| MultiClaimOnDelegationEnableEpoch: 65, | |||
| KeepExecOrderOnCreatedSCRsEnableEpoch: 64, | |||
There was a problem hiding this comment.
inconsistencies after merge
…h-checks # Conflicts: # go.mod # go.sum
…h-checks # Conflicts: # go.mod # go.sum
sasurobert
approved these changes
May 25, 2023
iulianpascalau
approved these changes
May 25, 2023
gabi-vuls
approved these changes
May 25, 2023
bogdan-rosianu
deleted the
MX-13962-consistent-tokens-values-length-checks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?