Add identifer in tsm #5258
Merged
Add identifer in tsm #5258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeniaminDrasovean
added
the
ignore-for-release-notes
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/sync-missing-trie-nodes #5258 +/- ##
================================================================
+ Coverage 79.46% 79.50% +0.04%
================================================================
Files 683 686 +3
Lines 88484 88808 +324
================================================================
+ Hits 70313 70607 +294
- Misses 13029 13040 +11
- Partials 5142 5161 +19
☔ View full report in Codecov by Sentry. |
testscommon/components/components.go
Outdated
| @@ -2,6 +2,7 @@ package components | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "github.com/multiversx/mx-chain-go/testscommon/storage" | |||
| @@ -117,6 +118,14 @@ func (s *MemDbMock) RangeKeys(handler func(key []byte, value []byte) bool) { | |||
| } | |||
| } | |||
|
|
|||
| func (s *MemDbMock) GetIdentifier() string { | |||
| } | ||
|
|
||
| return nil, core.NewGetNodeFromDBErrWithKey(n, err, dbWithID.GetIdentifier()) | ||
| return nil, core.NewGetNodeFromDBErrWithKey(n, err, db.GetIdentifier()) |
iulianpascalau
approved these changes
May 23, 2023
ssd04
approved these changes
May 23, 2023
BeniaminDrasovean
merged commit 4672b47
into
feat/sync-missing-trie-nodes
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?