Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rc/v1.6.0 in feat/balance data tries 23may #5268

Conversation

BeniaminDrasovean
Copy link
Contributor

Reasoning behind the pull request

  • Merge PR

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

miiu96 and others added 30 commits April 12, 2023 10:59
# Conflicts:
#	cmd/node/config/enableEpochs.toml
#	common/enablers/enableEpochsHandler.go
#	common/enablers/enableEpochsHandler_test.go
#	common/enablers/epochFlags.go
#	common/interface.go
#	config/epochConfig.go
#	config/tomlConfig_test.go
#	sharding/mock/enableEpochsHandlerMock.go
#	testscommon/enableEpochsHandlerStub.go
# Conflicts:
#	cmd/node/config/enableEpochs.toml
#	common/enablers/enableEpochsHandler.go
#	common/enablers/enableEpochsHandler_test.go
#	common/enablers/epochFlags.go
#	common/interface.go
#	config/epochConfig.go
#	config/tomlConfig_test.go
#	go.mod
#	go.sum
#	sharding/mock/enableEpochsHandlerMock.go
#	testscommon/enableEpochsHandlerStub.go
bogdan-rosianu and others added 24 commits May 17, 2023 13:48
…factor

Refactored transaction simulation construction
# Conflicts:
#	api/groups/blockGroup_test.go
#	factory/processing/export_test.go
#	factory/processing/processComponents_test.go
#	go.mod
#	go.sum
#	testscommon/components/components.go
# Conflicts:
#	factory/processing/blockProcessorCreator.go
#	factory/processing/export_test.go
…in-feat/balance-data-tries-23may

# Conflicts:
#	api/errors/errors.go
#	api/mock/facadeStub.go
#	common/enablers/enableEpochsHandler.go
#	common/enablers/enableEpochsHandler_test.go
#	common/enablers/epochFlags.go
#	common/interface.go
#	config/epochConfig.go
#	errors/errors.go
#	facade/initial/initialNodeFacade_test.go
#	facade/mock/nodeStub.go
#	factory/processing/processComponents.go
#	factory/statusCore/statusCoreComponents_test.go
#	go.mod
#	go.sum
#	integrationTests/interface.go
#	outport/factory/notifierFactory_test.go
#	outport/notifier/eventNotifier_test.go
#	sharding/mock/enableEpochsHandlerMock.go
#	testscommon/components/default.go
#	testscommon/enableEpochsHandlerMock/enableEpochsHandlerStub.go
#	trie/trieStorageManager_test.go
#	vm/systemSmartContracts/governance_test.go
#	vm/systemSmartContracts/validator_test.go
@BeniaminDrasovean BeniaminDrasovean added the ignore-for-release-notes Do not include item in release notes label May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 87.58% and project coverage change: +2.16 🎉

Comparison is base (e28ff0f) 77.44% compared to head (758cd8c) 79.61%.

❗ Current head 758cd8c differs from pull request most recent head db120b1. Consider uploading reports for the commit db120b1 to get more accurate results

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feat/balance-data-tries    #5268      +/-   ##
===========================================================
+ Coverage                    77.44%   79.61%   +2.16%     
===========================================================
  Files                          682      690       +8     
  Lines                        88995    89367     +372     
===========================================================
+ Hits                         68926    71147    +2221     
+ Misses                       14678    13004    -1674     
+ Partials                      5391     5216     -175     
Impacted Files Coverage Δ
api/middleware/responseLogger.go 66.66% <0.00%> (ø)
cmd/keygenerator/converter/pidPubkeyConverter.go 90.47% <ø> (ø)
...termui/view/termuic/termuiRenders/widgetsRender.go 2.94% <0.00%> (-0.04%) ⬇️
consensus/spos/bls/subroundStartRound.go 68.36% <0.00%> (ø)
factory/core/coreComponents.go 90.19% <ø> (+10.78%) ⬆️
factory/crypto/cryptoComponents.go 79.69% <ø> (+3.66%) ⬆️
factory/processing/txSimulatorProcessComponents.go 75.70% <ø> (ø)
factory/state/stateComponents.go 79.22% <ø> (+11.55%) ⬆️
factory/status/statusComponents.go 96.21% <ø> (+26.42%) ⬆️
factory/status/statusComponentsHandler.go 75.53% <ø> (+58.57%) ⬆️
... and 77 more

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeniaminDrasovean BeniaminDrasovean merged commit 6654e8d into feat/balance-data-tries May 23, 2023
5 checks passed
@BeniaminDrasovean BeniaminDrasovean deleted the merge-rc/v1.6.0-in-feat/balance-data-tries-23may branch May 23, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants