Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/trie sync optimizations #5291

Merged
merged 35 commits into from May 30, 2023
Merged

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented May 29, 2023

Reasoning behind the pull request

  • Improve trie sync process with parallelization

Proposed changes

  • Sync main trie and data tries in parallel
  • Avoid creating a trie structure and reading all leaves from it; sync data tries while syncing main trie

Testing procedure

  • Standard testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@ssd04 ssd04 self-assigned this May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 76.03% and project coverage change: +0.11 🎉

Comparison is base (d89e5d3) 79.79% compared to head (2cfa72a) 79.91%.

❗ Current head 2cfa72a differs from pull request most recent head 5d6daec. Consider uploading reports for the commit 5d6daec to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.6.0    #5291      +/-   ##
=============================================
+ Coverage      79.79%   79.91%   +0.11%     
=============================================
  Files            691      695       +4     
  Lines          89197    90009     +812     
=============================================
+ Hits           71179    71932     +753     
+ Misses         12888    12872      -16     
- Partials        5130     5205      +75     
Impacted Files Coverage Δ
common/channels.go 57.14% <0.00%> (-42.86%) ⬇️
common/trie.go 38.46% <0.00%> (-44.88%) ⬇️
state/baseAccount.go 62.96% <0.00%> (-7.41%) ⬇️
state/errors.go 25.00% <ø> (ø)
storage/database/db.go 66.66% <0.00%> (-33.34%) ⬇️
storage/storageunit/storageunit.go 100.00% <ø> (ø)
trie/keyBuilder/disabledKeyBuilder.go 77.77% <0.00%> (-22.23%) ⬇️
trie/keyBuilder/keyBuilder.go 91.30% <0.00%> (-8.70%) ⬇️
trie/leafNode.go 75.52% <ø> (-3.18%) ⬇️
trie/node.go 84.50% <ø> (-1.96%) ⬇️
... and 56 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

gabi-vuls
gabi-vuls previously approved these changes May 30, 2023
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.
@@ Log scanner @@

trie-sync-optimizations

================================================================================

  • Known Warnings 9
  • New Warnings 2
  • Known Errors 0
  • New Errors 0
  • Panics 0
    ================================================================================
  • block hash does not match 8568
  • wrong nonce in block 3494
  • miniblocks does not match 0
  • num miniblocks does not match 0
  • miniblock hash does not match 0
  • block bodies does not match 0
  • receipts hash missmatch 0
    ================================================================================
  • No jailed nodes on the testnet
    ================================================================================

@iulianpascalau iulianpascalau merged commit bf380c5 into rc/v1.6.0 May 30, 2023
5 checks passed
@iulianpascalau iulianpascalau deleted the feat/trie-sync-optimizations branch May 30, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants