Coverage for common package #5294
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5294 +/- ##
=============================================
+ Coverage 79.93% 80.16% +0.22%
=============================================
Files 695 695
Lines 90066 90070 +4
=============================================
+ Hits 71993 72203 +210
+ Misses 12868 12667 -201
+ Partials 5205 5200 -5
☔ View full report in Codecov by Sentry. |
| t.Parallel() | ||
|
|
||
| invalidPem := ` | ||
| -----BEGIN PRIVATE KEY for erd1ecdwux5tvanwryhr7cn5l9kc07ayquec7h2jc608kz0ycychzexsj6qw4j----- |
There was a problem hiding this comment.
Is this a known private key (e.g. Alice)? Also, this should be validPem, right?
There was a problem hiding this comment.
I created it for tests only.. renamed to validPem
|
|
||
| handler.EpochConfirmed(77, 0) | ||
| handler.EpochConfirmed(85, 0) |
There was a problem hiding this comment.
when we will merge the master -> rc/v1.5.0 -> rc/v1.6.0 this line will become handler.EpochConfirmed(math.MaxUint32, 0).
| }) | ||
| t.Run("flags with == condition should be set, along with all >=", func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| epoch := uint32(80) | ||
| epoch := uint32(85) |
There was a problem hiding this comment.
when we will merge the master -> rc/v1.5.0 -> rc/v1.6.0 this line will become epoch := uint32(math.MaxUint32).
| @@ -30,7 +31,7 @@ func NewSoftwareVersionFactory( | |||
| } | |||
|
|
|||
| // Create returns a software version checker object | |||
| func (svf *softwareVersionFactory) Create() (*softwareVersion.SoftwareVersionChecker, error) { | |||
| func (svf *softwareVersionFactory) Create() (statistics.SoftwareVersionChecker, error) { | |||
…into common_tests # Conflicts: # common/enablers/enableEpochsHandler_test.go
sstanculeanu
dismissed stale reviews from BeniaminDrasovean and iulianpascalau
via
3847405
…into common_tests # Conflicts: # common/enablers/enableEpochsHandler_test.go
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?