Coverage for genesis package #5301
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5301 +/- ##
=============================================
- Coverage 80.16% 80.02% -0.14%
=============================================
Files 695 695
Lines 90070 90053 -17
=============================================
- Hits 72203 72069 -134
- Misses 12667 12809 +142
+ Partials 5200 5175 -25
☔ View full report in Codecov by Sentry. |
| @@ -167,18 +167,12 @@ func checkArgumentsForBlockCreator(arg ArgsGenesisBlockCreator) error { | |||
| if check.IfNil(arg.Data.StorageService()) { | |||
| return process.ErrNilStore | |||
| } | |||
| if check.IfNil(arg.Data.Blockchain()) { | |||
|
|
||
| ap := parsing.NewTestAccountsParser(createMockHexPubkeyConverter()) | ||
| addr := ap.GenesisMintingAddress() | ||
| assert.Equal(t, hex.EncodeToString([]byte("erd17rc0pu8s7rc0pu8s7rc0pu8s7rc0pu8s7rc0pu8s7rc0pu8s7rcqqkhty3")), addr) |
There was a problem hiding this comment.
maybe extract minting address into a const since we have it in multiple places in this package
There was a problem hiding this comment.
[]byte("erd1...") is confusing. maybe use the real bech32 converter or use a hex / dummy address here
|
|
||
| ap := parsing.NewTestAccountsParser(createMockHexPubkeyConverter()) | ||
| addr := ap.GenesisMintingAddress() | ||
| assert.Equal(t, hex.EncodeToString([]byte("erd17rc0pu8s7rc0pu8s7rc0pu8s7rc0pu8s7rc0pu8s7rc0pu8s7rcqqkhty3")), addr) |
There was a problem hiding this comment.
[]byte("erd1...") is confusing. maybe use the real bech32 converter or use a hex / dummy address here
| t.Run("nil GasSchedule should error", func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| arg := createMockArgument(t, "testdata/genesisTest1.json", &mock.InitialNodesHandlerStub{}, big.NewInt(22000)) |
There was a problem hiding this comment.
System test passed.
@@ Log scanner @@
genesis_tests
================================================================================
- Known Warnings 8
- New Warnings 1
- Known Errors 1
- New Errors 0
- Panics 0
================================================================================ - block hash does not match 10909
- wrong nonce in block 3759
- miniblocks does not match 0
- num miniblocks does not match 0
- miniblock hash does not match 0
- block bodies does not match 0
- receipts hash missmatch 0
================================================================================ - No jailed nodes on the testnet
================================================================================
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?