Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage multiple network messengers on network components #5330

Merged

Conversation

sstanculeanu
Copy link
Contributor

Reasoning behind the pull request

  • handle multiple network messengers

Proposed changes

  • integrated latest mx-chain-communication-go and updated networkComponents to create and manage both messengers
  • added new fullArchiveP2P.toml file(for the moment just a copy of p2p.toml) + new flags
  • removed MetricP2PFullHistoryObservers which won't be needed anymore
  • removed FullHistoryList from diffPeerListCreator as it won't be needed anymore added the needed disabled components
  • added todos for further implementation

Testing procedure

  • will be tested with the feat branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

…ents to create and manage both messengers

added new fullArchiveP2P.toml file(for the moment just a copy of p2p.toml) + new flags
removed MetricP2PFullHistoryObservers which won't be needed anymore
removed FullHistoryList from diffPeerListCreator as it won't be needed anymore
added the needed disabled components
added todos for further implementation
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feat/multiple_p2p_messengers@2c6417b). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head e70f833 differs from pull request most recent head 1f8baff. Consider uploading reports for the commit 1f8baff to get more accurate results

Additional details and impacted files
@@                       Coverage Diff                       @@
##             feat/multiple_p2p_messengers    #5330   +/-   ##
===============================================================
  Coverage                                ?   80.29%           
===============================================================
  Files                                   ?      695           
  Lines                                   ?    90189           
  Branches                                ?        0           
===============================================================
  Hits                                    ?    72416           
  Misses                                  ?    12595           
  Partials                                ?     5178           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/node/config/fullArchiveP2P.toml Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
factory/disabled/networkMessenger.go Outdated Show resolved Hide resolved
factory/network/networkComponents.go Outdated Show resolved Hide resolved
factory/network/networkComponents.go Outdated Show resolved Hide resolved
integrationTests/factory/componentsHelper.go Outdated Show resolved Hide resolved
iulianpascalau
iulianpascalau previously approved these changes Jun 8, 2023
cmd/node/config/fullArchiveP2P.toml Outdated Show resolved Hide resolved
factory/network/networkComponents.go Show resolved Hide resolved
factory/network/networkComponents.go Show resolved Hide resolved
@sstanculeanu sstanculeanu merged commit f05af2b into feat/multiple_p2p_messengers Jun 9, 2023
4 checks passed
@sstanculeanu sstanculeanu deleted the integrate_latest_communication branch June 9, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants