Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata endpoint #5353

Merged
merged 3 commits into from Jun 19, 2023
Merged

Metadata endpoint #5353

merged 3 commits into from Jun 19, 2023

Conversation

matei-p
Copy link
Contributor

@matei-p matei-p commented Jun 16, 2023

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@matei-p matei-p changed the base branch from master to feat/vm1.5 June 16, 2023 08:03
@matei-p matei-p marked this pull request as ready for review June 16, 2023 08:30
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 82.96% and project coverage change: +0.77 🎉

Comparison is base (25c4f23) 78.87% compared to head (5c5bd4b) 79.65%.

❗ Current head 5c5bd4b differs from pull request most recent head 0e6f368. Consider uploading reports for the commit 0e6f368 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           feat/vm1.5    #5353      +/-   ##
==============================================
+ Coverage       78.87%   79.65%   +0.77%     
==============================================
  Files             688      703      +15     
  Lines           90390    92465    +2075     
==============================================
+ Hits            71299    73652    +2353     
+ Misses          13754    13464     -290     
- Partials         5337     5349      +12     
Impacted Files Coverage Δ
api/groups/blockGroup.go 97.95% <ø> (ø)
api/middleware/responseLogger.go 66.66% <0.00%> (ø)
common/channels.go 57.14% <0.00%> (-42.86%) ⬇️
common/trie.go 38.46% <0.00%> (-44.88%) ⬇️
consensus/spos/bls/subroundStartRound.go 68.36% <0.00%> (ø)
...ataRetriever/dataPool/headersCache/headersCache.go 90.15% <ø> (+10.60%) ⬆️
epochStart/shardchain/trigger.go 65.89% <0.00%> (ø)
factory/core/coreComponents.go 90.29% <ø> (ø)
node/external/blockAPI/metaBlock.go 78.49% <ø> (ø)
node/external/blockAPI/shardBlock.go 75.18% <ø> (ø)
... and 57 more

... and 108 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matei-p matei-p merged commit e6f6d2e into feat/vm1.5 Jun 19, 2023
5 checks passed
@matei-p matei-p deleted the metadata-endpoint branch June 19, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants