Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed peers monitor #5356

Merged
merged 1 commit into from Jun 20, 2023
Merged

Conversation

sstanculeanu
Copy link
Contributor

Reasoning behind the pull request

  • new component needed to provided managed keys info

Proposed changes

  • created managedPeersMonitor

Testing procedure

  • will be tested with the full feat branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feat/multikey_metrics@03438af). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 31b2ab9 differs from pull request most recent head f8a1f1b. Consider uploading reports for the commit f8a1f1b to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                    @@
##             feat/multikey_metrics    #5356   +/-   ##
========================================================
  Coverage                         ?   80.27%           
========================================================
  Files                            ?      697           
  Lines                            ?    90246           
  Branches                         ?        0           
========================================================
  Hits                             ?    72448           
  Misses                           ?    12624           
  Partials                         ?     5174           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iulianpascalau iulianpascalau self-requested a review June 20, 2023 10:30
}

sort.Slice(managedKeys, func(i, j int) bool {
return string(managedKeys[i]) < string(managedKeys[j])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sstanculeanu sstanculeanu merged commit 66f5613 into feat/multikey_metrics Jun 20, 2023
4 checks passed
@sstanculeanu sstanculeanu deleted the managed_peers_monitor branch June 20, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants