New API endpoints for managed keys #5357
Conversation
sstanculeanu
added
area:node-api
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/multikey_metrics #5357 +/- ##
=========================================================
+ Coverage 80.27% 80.31% +0.03%
=========================================================
Files 697 697
Lines 90246 90355 +109
=========================================================
+ Hits 72448 72570 +122
+ Misses 12624 12608 -16
- Partials 5174 5177 +3
☔ View full report in Codecov by Sentry. |
api/groups/nodeGroup.go
Outdated
| return | ||
| } | ||
|
|
||
| keys, err := ng.getFacade().GetEligibleManagedKeys(epoch) |
There was a problem hiding this comment.
this works for older epochs but won't work for future epochs. Do you think it is relevant to keep the epoch parameter? I think the use case will be to check the current epoch status.
There was a problem hiding this comment.
right, would make more sense.. updated
api/groups/nodeGroup.go
Outdated
| c.JSON( | ||
| http.StatusOK, | ||
| shared.GenericAPIResponse{ | ||
| Data: gin.H{"keys": keys}, |
api/groups/nodeGroup.go
Outdated
| c.JSON( | ||
| http.StatusOK, | ||
| shared.GenericAPIResponse{ | ||
| Data: gin.H{"keys": keys}, |
| } | ||
| return make([][]byte, 0), nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Missing comment.
Reasoning behind the pull request
Proposed changes
node/managed-keys/countfor the total number of managed keysnode/managed-keys/eligible/:epochfor the eligible keys managed, in a specific epoch, from the same shard as the nodenode/managed-keys/waiting/:epochfor the waiting keys managed, in a specific epoch, from the same shard as the nodeTesting procedure
Response examples:
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?