Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in import-db for rc/v1.6.0 #5522

Merged
merged 7 commits into from Aug 25, 2023
Merged

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Aug 24, 2023

Reasoning behind the pull request

  • during import-db, on metachain node, the peer state trie size increased continuously
  • during import-db, we had warnings like wrong assertion type when creating peer authentication requester

Proposed changes

  • call the trieStorageManager.ExitPruningBufferingMode() in the earlySnapshotCompletion function. Skip the waiting for new epoch in case the node is in import-db mode in function waitForStorageEpochChange.

Testing procedure

  • standard system test
  • import-db

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04% ⚠️

Comparison is base (9986b2e) 80.07% compared to head (b0a39d7) 80.03%.
Report is 1 commits behind head on rc/v1.6.0.

❗ Current head b0a39d7 differs from pull request most recent head 6122d86. Consider uploading reports for the commit 6122d86 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.6.0    #5522      +/-   ##
=============================================
- Coverage      80.07%   80.03%   -0.04%     
=============================================
  Files            708      708              
  Lines          93692    93696       +4     
=============================================
- Hits           75021    74994      -27     
- Misses         13321    13351      +30     
- Partials        5350     5351       +1     
Files Changed Coverage Δ
state/snapshotsManager.go 97.45% <100.00%> (+0.90%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau changed the title [WIP]Fixes in import-db for rc/v1.6.0 Fixes in import-db for rc/v1.6.0 Aug 24, 2023
bogdan-rosianu
bogdan-rosianu previously approved these changes Aug 24, 2023
sstanculeanu
sstanculeanu previously approved these changes Aug 24, 2023
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.5.13-dev-config-8c685c8e00 -> fixes-import-db-2023.08.24-e194f576f4

--- Specific errors ---

block hash does not match 7464
wrong nonce in block 2451
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 1
Nr. of all WARNS: 169
Nr. of new ERRORS: 0
Nr. of new WARNS: 1
Nr. of PANICS: 0

@iulianpascalau iulianpascalau merged commit 1a3f0f2 into rc/v1.6.0 Aug 25, 2023
6 checks passed
@iulianpascalau iulianpascalau deleted the fixes-import-db-2023.08.24 branch August 25, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants