Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestOnlyProcessingNode - part 1 #5552

Merged
merged 2 commits into from Sep 4, 2023

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • started work on the testOnlyProcessingNode

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@iulianpascalau iulianpascalau changed the title [TestOnlyProcessingNode - part 1 [WIP]TestOnlyProcessingNode - part 1 Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feat/test-only-processor-node@499960e). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 234ac60 differs from pull request most recent head 1dea560. Consider uploading reports for the commit 1dea560 to get more accurate results

Additional details and impacted files
@@                       Coverage Diff                        @@
##             feat/test-only-processor-node    #5552   +/-   ##
================================================================
  Coverage                                 ?   80.04%           
================================================================
  Files                                    ?      711           
  Lines                                    ?    93843           
  Branches                                 ?        0           
================================================================
  Hits                                     ?    75120           
  Misses                                   ?    13363           
  Partials                                 ?     5360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miiu96 miiu96 changed the title [WIP]TestOnlyProcessingNode - part 1 TestOnlyProcessingNode - part 1 Sep 1, 2023
Comment on lines +19 to +21
err = toml.Unmarshal(data, config)

return err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
err = toml.Unmarshal(data, config)
return err
return toml.Unmarshal(data, config)

@miiu96 miiu96 merged commit b4d5fe7 into feat/test-only-processor-node Sep 4, 2023
5 checks passed
@miiu96 miiu96 deleted the processing-node-part1 branch September 4, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants