Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added synced net messenger #5575

Merged
merged 5 commits into from Sep 12, 2023

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • added syncedNetworkMessenger

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@iulianpascalau iulianpascalau changed the base branch from feat/test-only-processor-node to state-core-and-state-components September 11, 2023 15:42
@iulianpascalau iulianpascalau marked this pull request as draft September 11, 2023 15:42
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 83.41% and no project coverage change.

Comparison is base (9768b16) 79.96% compared to head (6bcd6d0) 79.97%.
Report is 1 commits behind head on feat/test-only-processor-node.

❗ Current head 6bcd6d0 differs from pull request most recent head 77b84b8. Consider uploading reports for the commit 77b84b8 to get more accurate results

Additional details and impacted files
@@                       Coverage Diff                       @@
##           feat/test-only-processor-node    #5575    +/-   ##
===============================================================
  Coverage                          79.96%   79.97%            
===============================================================
  Files                                716      718     +2     
  Lines                              94122    94333   +211     
===============================================================
+ Hits                               75267    75440   +173     
- Misses                             13470    13500    +30     
- Partials                            5385     5393     +8     
Files Changed Coverage Δ
node/processingOnlyNode/syncedMessenger.go 83.00% <83.00%> (ø)
node/processingOnlyNode/syncedBroadcastNetwork.go 84.48% <84.48%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from state-core-and-state-components to feat/test-only-processor-node September 12, 2023 09:19
@iulianpascalau iulianpascalau marked this pull request as ready for review September 12, 2023 09:33
@iulianpascalau iulianpascalau self-assigned this Sep 12, 2023
@iulianpascalau iulianpascalau merged commit b331b01 into feat/test-only-processor-node Sep 12, 2023
5 checks passed
@iulianpascalau iulianpascalau deleted the synced-net-messenger branch September 12, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants