Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto components #5576

Merged
merged 6 commits into from Sep 12, 2023
Merged

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Sep 12, 2023

Reasoning behind the pull request

  • CryptoComponents

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@miiu96 miiu96 marked this pull request as ready for review September 12, 2023 11:34
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 37.50% and project coverage change: -0.06% ⚠️

Comparison is base (a9e8794) 80.01% compared to head (d15b092) 79.95%.
Report is 1 commits behind head on feat/test-only-processor-node.

❗ Current head d15b092 differs from pull request most recent head 48c3c01. Consider uploading reports for the commit 48c3c01 to get more accurate results

Additional details and impacted files
@@                        Coverage Diff                        @@
##           feat/test-only-processor-node    #5576      +/-   ##
=================================================================
- Coverage                          80.01%   79.95%   -0.06%     
=================================================================
  Files                                718      719       +1     
  Lines                              94335    94455     +120     
=================================================================
+ Hits                               75478    75525      +47     
- Misses                             13464    13531      +67     
- Partials                            5393     5399       +6     
Files Changed Coverage Δ
node/processingOnlyNode/cryptoComponents.go 34.23% <34.23%> (ø)
node/processingOnlyNode/testOnlyProcessingNode.go 74.44% <77.77%> (+0.37%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"github.com/multiversx/mx-chain-go/vm"
)

type ArgsCryptoComponentsHolder struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comments on all exported items

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -0,0 +1,4 @@
-----BEGIN PRIVATE KEY for 75907bf66c64949f8d1dd003ed8fd815e8dec189a9e50e4bfd7e2592cfdc92641baf500e3533820e0f58c4ed3f39c01750f0017726731fe5bc66a0ab6fc9a7b5661d163e72f099fe29df16fd59ded198dc1423575be1b6e2160e0d84a5ece08a-----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need another approach here.
We can leave it as it is and I will fix this in an upcoming PR

@iulianpascalau iulianpascalau merged commit 165b24a into feat/test-only-processor-node Sep 12, 2023
5 checks passed
@iulianpascalau iulianpascalau deleted the crypto-components branch September 12, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants