Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added network components in chain simulator #5578

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • renamed the package
  • added networkComponents

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

- added networkComponents
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 37.77% and project coverage change: -0.06% ⚠️

Comparison is base (d15b092) 79.95% compared to head (656ea2d) 79.90%.
Report is 1 commits behind head on feat/test-only-processor-node.

❗ Current head 656ea2d differs from pull request most recent head 6dd5b7b. Consider uploading reports for the commit 6dd5b7b to get more accurate results

Additional details and impacted files
@@                        Coverage Diff                        @@
##           feat/test-only-processor-node    #5578      +/-   ##
=================================================================
- Coverage                          79.95%   79.90%   -0.06%     
=================================================================
  Files                                719      720       +1     
  Lines                              94455    94499      +44     
=================================================================
- Hits                               75525    75506      -19     
- Misses                             13531    13591      +60     
- Partials                            5399     5402       +3     
Files Changed Coverage Δ
node/chainSimulator/configLoaders.go 65.51% <ø> (ø)
node/chainSimulator/coreComponents.go 50.56% <ø> (ø)
node/chainSimulator/cryptoComponents.go 34.23% <ø> (ø)
node/chainSimulator/memoryComponents.go 100.00% <ø> (ø)
node/chainSimulator/stateComponents.go 46.93% <ø> (ø)
node/chainSimulator/statusComponents.go 47.36% <ø> (ø)
node/chainSimulator/statusCoreComponents.go 50.00% <ø> (ø)
node/chainSimulator/storageService.go 100.00% <ø> (ø)
node/chainSimulator/syncedBroadcastNetwork.go 84.48% <ø> (ø)
node/chainSimulator/testOnlyProcessingNode.go 73.11% <33.33%> (ø)
... and 2 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau merged commit d5be161 into feat/test-only-processor-node Sep 13, 2023
6 checks passed
@iulianpascalau iulianpascalau deleted the chain-simulator-network-components branch September 13, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants