New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added p2p debugger setter #5587
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5587 +/- ##
=============================================
- Coverage 80.09% 80.08% -0.01%
=============================================
Files 706 706
Lines 93733 93744 +11
=============================================
+ Hits 75074 75077 +3
- Misses 13324 13331 +7
- Partials 5335 5336 +1
☔ View full report in Codecov by Sentry. |
go.mod
Outdated
@@ -13,7 +13,7 @@ require ( | |||
github.com/google/gops v0.3.18 | |||
github.com/gorilla/websocket v1.5.0 | |||
github.com/mitchellh/mapstructure v1.5.0 | |||
github.com/multiversx/mx-chain-communication-go v1.0.6 | |||
github.com/multiversx/mx-chain-communication-go v1.0.7-0.20230918095306-97f7d8d179bf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proper release after testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal allin test: v1.5.13-dev-config-8c685c8e00 -> p2p_debugger_update-9770fd4be1
--- Specific errors ---
block hash does not match 4123
wrong nonce in block 1650
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 170
Nr. of new ERRORS: 0
Nr. of new WARNS: 15
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
cp-test-02-validator-14 :
Warn: subroundSignature.doSignatureConsensusCheck: fallback validation has been applied minimum number of signatures required = actual number of signatures received = 15
/------/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current warnings will be solved with a future PR.
47e9644
Reasoning behind the pull request
Proposed changes
Testing procedure
/node/p2pstatus
must have metrics ending with _full_archive, which should reflect the actual state of the networkPre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?