Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added p2p debugger setter #5587

Merged
merged 5 commits into from Sep 27, 2023
Merged

Added p2p debugger setter #5587

merged 5 commits into from Sep 27, 2023

Conversation

sstanculeanu
Copy link
Contributor

@sstanculeanu sstanculeanu commented Sep 18, 2023

Reasoning behind the pull request

  • using the same logger on all messenger components led to difficulties during debugging

Proposed changes

  • added setter for p2p debugger, as it could be optional and set later on from node
  • added p2p metrics for full archive network

Testing procedure

  • system test with some nodes on full archive network
  • on full archive nodes, /node/p2pstatus must have metrics ending with _full_archive, which should reflect the actual state of the network

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (afefa0a) 80.09% compared to head (219e178) 80.08%.
Report is 1 commits behind head on rc/v1.6.0.

❗ Current head 219e178 differs from pull request most recent head 47e9644. Consider uploading reports for the commit 47e9644 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.6.0    #5587      +/-   ##
=============================================
- Coverage      80.09%   80.08%   -0.01%     
=============================================
  Files            706      706              
  Lines          93733    93744      +11     
=============================================
+ Hits           75074    75077       +3     
- Misses         13324    13331       +7     
- Partials        5335     5336       +1     
Files Coverage Δ
common/converters.go 100.00% <100.00%> (ø)
factory/network/networkComponents.go 87.20% <33.33%> (-0.96%) ⬇️
factory/status/statusComponentsHandler.go 73.46% <54.54%> (-1.85%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Outdated
@@ -13,7 +13,7 @@ require (
github.com/google/gops v0.3.18
github.com/gorilla/websocket v1.5.0
github.com/mitchellh/mapstructure v1.5.0
github.com/multiversx/mx-chain-communication-go v1.0.6
github.com/multiversx/mx-chain-communication-go v1.0.7-0.20230918095306-97f7d8d179bf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proper release after testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ssd04 ssd04 self-requested a review September 19, 2023 06:53
ssd04
ssd04 previously approved these changes Sep 19, 2023
gabi-vuls
gabi-vuls previously approved these changes Sep 26, 2023
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.5.13-dev-config-8c685c8e00 -> p2p_debugger_update-9770fd4be1

--- Specific errors ---

block hash does not match 4123
wrong nonce in block 1650
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 170
Nr. of new ERRORS: 0
Nr. of new WARNS: 15
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

cp-test-02-validator-14 :
Warn: subroundSignature.doSignatureConsensusCheck: fallback validation has been applied minimum number of signatures required = actual number of signatures received = 15

/------/

iulianpascalau
iulianpascalau previously approved these changes Sep 26, 2023
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current warnings will be solved with a future PR.

@sstanculeanu sstanculeanu merged commit bf2e6a7 into rc/v1.6.0 Sep 27, 2023
6 checks passed
@sstanculeanu sstanculeanu deleted the p2p_debugger_update branch September 27, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants