Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fallback on topicRequestSender in case requests on full archive nodes fail #5604

Merged
merged 3 commits into from Oct 3, 2023

Conversation

sstanculeanu
Copy link
Contributor

Reasoning behind the pull request

  • there might be a possibility when running a regular node,

Proposed changes

  • add a fallback option.. if the requests sent on full archive network fail, try on the regular one

Testing procedure

  • standard system test

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu self-assigned this Sep 26, 2023
Base automatically changed from p2p_debugger_update to rc/v1.6.0 September 27, 2023 20:32
@sstanculeanu sstanculeanu marked this pull request as ready for review September 27, 2023 20:32
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c10cdea) 80.15% compared to head (ac5f985) 80.16%.
Report is 1 commits behind head on rc/v1.6.0.

❗ Current head ac5f985 differs from pull request most recent head e190b68. Consider uploading reports for the commit e190b68 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           rc/v1.6.0    #5604   +/-   ##
==========================================
  Coverage      80.15%   80.16%           
==========================================
  Files            708      708           
  Lines          93850    93860   +10     
==========================================
+ Hits           75225    75241   +16     
+ Misses         13288    13282    -6     
  Partials        5337     5337           
Files Coverage Δ
dataRetriever/topicSender/topicRequestSender.go 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sstanculeanu sstanculeanu merged commit 599d921 into rc/v1.6.0 Oct 3, 2023
6 checks passed
@sstanculeanu sstanculeanu deleted the topic_request_fallback branch October 3, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants