Data components and process components #5625
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/test-only-processor-node #5625 +/- ##
=================================================================
- Coverage 80.02% 79.42% -0.61%
=================================================================
Files 721 723 +2
Lines 94703 95020 +317
=================================================================
- Hits 75786 75469 -317
- Misses 13519 14199 +680
+ Partials 5398 5352 -46
☔ View full report in Codecov by Sentry. |
| if err != nil { | ||
| return nil, err | ||
| } | ||
| // TODO check if this is needed |
There was a problem hiding this comment.
can be a mock/disabled instance, no cache needed
| } | ||
|
|
||
| // TODO check if this is needed | ||
| whiteListerVerifiedTxs, err := createWhiteListerVerifiedTxs(&args.Config) |
There was a problem hiding this comment.
can be a mock/disabled instance, no cache needed
| return instance, nil | ||
| } | ||
|
|
||
| func createWhiteListerVerifiedTxs(generalConfig *config.Config) (process.WhiteListHandler, error) { |
| pathForMainConfig = "../../cmd/node/config/config.toml" | ||
| pathForEconomicsConfig = "../../cmd/node/config/economics.toml" | ||
| pathForGasSchedules = "../../cmd/node/config/gasSchedules" | ||
| nodesSetupConfig = "../../cmd/node/config/nodesSetup.json" |
There was a problem hiding this comment.
as stated, we need to generate this along with the genesis.json file in a new PR. Also, we need to copy these files into a temporary directory because of this.
There was a problem hiding this comment.
I will change in the next PR
| @@ -0,0 +1,18 @@ | |||
| [ | |||
| { | |||
There was a problem hiding this comment.
I guess we can provide an empty file for this. No need to deploy SCs at genesis time as this takes a lot of time.
There was a problem hiding this comment.
will change in the next PR because also have to change the genesis.json file
Reasoning behind the pull request
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?