Fixing hyperblock partial mb handling - part1 #5638
Conversation
…lock-partial-mb-handling-part1
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/dblookupext-partial-miniblocks #5638 +/- ##
=======================================================================
- Coverage 80.16% 80.12% -0.04%
=======================================================================
Files 708 709 +1
Lines 93875 93982 +107
=======================================================================
+ Hits 75254 75305 +51
- Misses 13283 13328 +45
- Partials 5338 5349 +11
☔ View full report in Codecov by Sentry. |
…dling-part1' into fixing-hyperblock-partial-mb-handling-part1
| TxHashesWhenPartial: nil, | ||
| IndexOfFirstTxProcessed: 0, |
There was a problem hiding this comment.
Re-indexing (db lookup extensions) from the epoch that enabled partial miniblocks needed, though.
There was a problem hiding this comment.
yes, to fix old, broken, miniblocks
| mbHandler := createMockMiniblocksHandler() | ||
|
|
||
| header1 := &block.Header{ | ||
| Epoch: 37, |
| } | ||
|
|
||
| for index, mb := range blockBody.MiniBlocks { | ||
| miniblockHash, err := core.CalculateHash(mh.marshaller, mh.hasher, mb) |
There was a problem hiding this comment.
L31-34 can be moved inside handleMiniblock func
There was a problem hiding this comment.
this will overcomplicate the returning errors on handleMiniblock as I want to know the miniblock hash when wrapping the error on L38
dblookupext/miniblocksHandler.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (mh *miniblocksHandler) getExecutedTxHashes(miniblockHeader data.MiniBlockHeaderHandler, mb *block.MiniBlock) [][]byte { |
There was a problem hiding this comment.
getOrderedExecutedTxHashes ?
dblookupext/miniblocksHandler.go
Outdated
| NumTxHashesInMiniblock: int32(len(mb.TxHashes)), | ||
| } | ||
|
|
||
| var txHasheshenPartial [][]byte |
dblookupext/miniblocksHandler.go
Outdated
| func (mh *miniblocksHandler) loadExistingMiniblocksMetadata(miniblockHash []byte, epoch uint32) (*MiniblockMetadataV2, error) { | ||
| multipleMiniblockMetadata := &MiniblockMetadataV2{} | ||
| buff, err := mh.miniblocksMetadataStorer.GetFromEpoch(miniblockHash, epoch) | ||
| if err == storage.ErrKeyNotFound { |
iulianpascalau
merged commit bf8217d
into
feat/dblookupext-partial-miniblocks
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?