lastSnapshot marker fix #5642
lastSnapshot marker fix #5642
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.0 #5642 +/- ##
=============================================
- Coverage 80.34% 80.31% -0.04%
=============================================
Files 708 710 +2
Lines 94096 94132 +36
=============================================
Hits 75601 75601
- Misses 13187 13220 +33
- Partials 5308 5311 +3
☔ View full report in Codecov by Sentry. |
state/snapshotsManager.go
Outdated
| err := trieStorageManager.PutInEpoch([]byte(lastSnapshot), rootHash, epoch) | ||
| handleLoggingWhenError("could not set lastSnapshot", err, "rootHash", rootHash) | ||
| }() | ||
| go sm.lastSnapshotMarker.AddMarker(trieStorageManager, epoch, rootHash) |
There was a problem hiding this comment.
AddMarker will check internally for WaitForStorageEpochChange , should we avoid that in ImportDB processing mode?
There was a problem hiding this comment.
Indeed, there is no need for this if we run in importDB mode.
| if check.IfNil(args.LastSnapshotMarker) { | ||
| return nil, ErrNilLastSnapshotMarker |
There was a problem hiding this comment.
unit test for nil check LastSnapshotMarker?
…e-migration change gas cost for migrate data trie built in function
chore: fixed create release workflow
…ion-example update guardians tx construction example
| @@ -10,7 +10,7 @@ import ( | |||
| logger "github.com/multiversx/mx-chain-logger-go" | |||
| ) | |||
|
|
|||
| var log = logger.GetOrCreate("state") | |||
| var log = logger.GetOrCreate("storage") | |||
There was a problem hiding this comment.
storage/storageEpochChange to comply with the rest of the project
There was a problem hiding this comment.
Normal allin test: v1.5.13-dev-config-8c685c8e00 -> test-last-snapshot-marker--53d20a600c
--- Specific errors ---
block hash does not match 8716
wrong nonce in block 2958
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 385
Nr. of new ERRORS: 0
Nr. of new WARNS: 20
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
/------/
BeniaminDrasovean
dismissed stale reviews from gabi-vuls, ssd04, and iulianpascalau
The base branch was changed.
Reasoning behind the pull request
lastSnapshotmarker was put in the new epoch before the storers could actually open the new epoch storer. This triggered anWARNprint, and the marker was not saved to storage.Proposed changes
PutInEpochfor thelastSnapshotmarker, wait for the storers to change epochs.lastSnapshotmarker operationsTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?