Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SendTxRequest with FrontendTransaction #5649

Merged
merged 2 commits into from Oct 16, 2023

Conversation

sstanculeanu
Copy link
Contributor

@sstanculeanu sstanculeanu commented Oct 10, 2023

Reasoning behind the pull request

  • SendTxRequest struct, used only on node api, can be replaced by FrontendTransaction for consistency

Proposed changes

  • replace structures

Testing procedure

  • standard system test with txs

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu self-assigned this Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b209c7f) 80.34% compared to head (69ff36e) 80.26%.
Report is 1 commits behind head on rc/v1.7.0.

❗ Current head 69ff36e differs from pull request most recent head 16e5d20. Consider uploading reports for the commit 16e5d20 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.7.0    #5649      +/-   ##
=============================================
- Coverage      80.34%   80.26%   -0.08%     
=============================================
  Files            708      706       -2     
  Lines          94096    93908     -188     
=============================================
- Hits           75601    75378     -223     
- Misses         13187    13223      +36     
+ Partials        5308     5307       -1     
Files Coverage Δ
api/groups/transactionGroup.go 98.31% <100.00%> (ø)

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


// SendTxRequest represents the structure that maps and validates user input for publishing a new transaction
type SendTxRequest struct {
Sender string `form:"sender" json:"sender"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
the transaction.FrontendTransaction's fields matches this one

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.5.13-dev-config-8c685c8e00 -> remove_sendtxrequest-16e5d20bd2

--- Specific errors ---

block hash does not match 1915
wrong nonce in block 647
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 1
Nr. of all WARNS: 124
Nr. of new ERRORS: 1
Nr. of new WARNS: 1
Nr. of PANICS: 0

/------/

--- ERRORS ---

mx-testnet-gcp-mil-obs-0 :
Error: context deadline exceeded while closing the http server in gin/webServer 1

/------/

--- WARNINGS ---

mx-testnet-gcp-mil-node-29 :
Warn: trie recreate error: error = getNodeFromDB error: key not found for key root = 1

/------/

@sstanculeanu sstanculeanu merged commit 46f6022 into rc/v1.7.0 Oct 16, 2023
6 checks passed
@sstanculeanu sstanculeanu deleted the remove_sendtxrequest branch October 16, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants