remove the state checkpoint operation #5672
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.0 #5672 +/- ##
=============================================
+ Coverage 80.31% 80.34% +0.02%
=============================================
Files 710 708 -2
Lines 94132 93768 -364
=============================================
- Hits 75601 75335 -266
+ Misses 13220 13149 -71
+ Partials 5311 5284 -27
☔ View full report in Codecov by Sentry. |
| if check.IfNil(args.Marshalizer) { | ||
| return nil, ErrNilMarshalizer | ||
| } | ||
| if check.IfNil(args.Hasher) { | ||
| return nil, ErrNilHasher | ||
| } | ||
| if check.IfNil(args.CheckpointHashesHolder) { | ||
| return nil, ErrNilCheckpointHashesHolder |
There was a problem hiding this comment.
i think ErrNilCheckpointHashesHolder has to be removed as well
| _ = adb.GetStackDebugFirstEntry() | ||
| case 22: | ||
| case 21: |
There was a problem hiding this comment.
change the modulo value on L2889?
| @@ -284,7 +254,6 @@ func (sm *snapshotsManager) earlySnapshotCompletion(stats *snapshotStatistics, t | |||
| } | |||
|
|
|||
| func (sm *snapshotsManager) snapshotUserAccountDataTrie( | |||
| isSnapshot bool, | |||
| } | ||
|
|
||
| return stsm.getFromOtherStorers(key) | ||
| stsm.putInPreviousStorerIfAbsent(key, val, epoch) |
There was a problem hiding this comment.
is this change ok? On the old code we called stsm.getFromOtherStorers(key)
There was a problem hiding this comment.
It is ok. If the value was not found, it would have tried to get it from the checkpoints storer. But since we have removed the checkpoints storer, I also removed the stsm.getFromOtherStorers(key).
| "github.com/multiversx/mx-chain-go/common" | ||
| "github.com/multiversx/mx-chain-go/testscommon/storageManager" | ||
| "testing" |
There was a problem hiding this comment.
Normal allin test: v1.5.13-dev-config-8c685c8e00 -> remove-state-checkpoint-op-c37ba204b1
--- Specific errors ---
block hash does not match 8248
wrong nonce in block 2897
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 1
Nr. of all WARNS: 611
Nr. of new ERRORS: 1
Nr. of new WARNS: 34
Nr. of PANICS: 0
/------/
--- ERRORS ---
gcp-bel-validator-17 :
Error: bootstrapDataComponentsFactory create() failed: bootstrap process has failed: time is out 1
/------/
--- WARNINGS ---
/------/
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?