Create configs #5677
Merged
Create configs #5677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/test-only-processor-node #5677 +/- ##
=================================================================
- Coverage 79.42% 79.25% -0.18%
=================================================================
Files 723 724 +1
Lines 95020 95203 +183
=================================================================
- Hits 75469 75452 -17
- Misses 14199 14399 +200
Partials 5352 5352
☔ View full report in Codecov by Sentry. |
| ) | ||
|
|
||
| const ( | ||
| genesisAddressWithStake = "erd10z6sdhwfy8jtuf87j5gnq7lt7fd2wfmhkg8zfzf79lrapzq265yqlnmtm7" |
There was a problem hiding this comment.
I would export all these constants. Even the private keys.
Maybe declare the private keys in hex format?
| return os.WriteFile(validatorsFile, buff.Bytes(), 0644) | ||
| } | ||
|
|
||
| func modifyFile(fileName string, f func(i []byte) ([]byte, error)) error { |
There was a problem hiding this comment.
not a big fan of providing a function pointer. Do we really need this or we can simplify the function signature?
bogdan-rosianu
previously approved these changes
Nov 6, 2023
iulianpascalau
approved these changes
Nov 7, 2023
ssd04
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?