process blocks #5681
process blocks #5681
Conversation
# Conflicts: # node/chainSimulator/chainSimulator.go # node/chainSimulator/components/testOnlyProcessingNode.go # node/chainSimulator/interface.go
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/test-only-processor-node #5681 +/- ##
==============================================================
Coverage 79.26% 79.26%
==============================================================
Files 724 724
Lines 95190 95210 +20
==============================================================
+ Hits 75452 75471 +19
+ Misses 14386 14385 -1
- Partials 5352 5354 +2
☔ View full report in Codecov by Sentry. |
| @@ -151,11 +151,6 @@ func NewTestOnlyProcessingNode(args ArgsTestOnlyProcessingNode) (*testOnlyProces | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| err = instance.createTransactionLogProcessor() | |||
There was a problem hiding this comment.
We need the tx logs processor. Please put back the code
There was a problem hiding this comment.
the logs processor is created inside the process components.
| blsKeyBytes []byte | ||
| } | ||
|
|
||
| func NewBlocksCreator(nodeHandler NodeHandler, blsKeyBytes []byte) (*blocksCreator, error) { |
| currentHeader := creator.nodeHandler.GetChainHandler().GetCurrentBlockHeader() | ||
| var nonce, round uint64 | ||
| var prevHash, prevRandSeed []byte | ||
| if currentHeader != nil { |
There was a problem hiding this comment.
please extract in a function L23 - L34
| return err | ||
| } | ||
|
|
||
| err = newHeader.SetChainID([]byte("chain")) |
There was a problem hiding this comment.
"chain" should be a const and used also in node/chainSimulator/configs/configs.go L51
| nonce, round = currentHeader.GetNonce(), currentHeader.GetRound() | ||
| prevHash = creator.nodeHandler.GetChainHandler().GetCurrentBlockHeaderHash() | ||
| prevRandSeed = currentHeader.GetRandSeed() | ||
| } else { |
There was a problem hiding this comment.
could have omitted the "else" branch and return on L101
| }, nil | ||
| } | ||
|
|
||
| // CreateNewBlock create and process a new block |
There was a problem hiding this comment.
| // CreateNewBlock create and process a new block | |
| // CreateNewBlock creates and process a new block |
?
There was a problem hiding this comment.
fixing in the next PR
Reasoning behind the pull request
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?