Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added & integrated manual round handler #5684

Merged
merged 8 commits into from Nov 8, 2023

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • added & integrated manual round handler

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Base automatically changed from process-blocks to feat/test-only-processor-node November 7, 2023 15:14
@iulianpascalau iulianpascalau marked this pull request as ready for review November 7, 2023 15:14
miiu96
miiu96 previously approved these changes Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (a0dd10a) 79.26% compared to head (1588b6b) 79.19%.
Report is 1 commits behind head on feat/test-only-processor-node.

❗ Current head 1588b6b differs from pull request most recent head b308a29. Consider uploading reports for the commit b308a29 to get more accurate results

Additional details and impacted files
@@                        Coverage Diff                        @@
##           feat/test-only-processor-node    #5684      +/-   ##
=================================================================
- Coverage                          79.26%   79.19%   -0.08%     
=================================================================
  Files                                724      725       +1     
  Lines                              95210    95231      +21     
=================================================================
- Hits                               75471    75420      -51     
- Misses                             14385    14456      +71     
- Partials                            5354     5355       +1     
Files Coverage Δ
node/chainSimulator/components/coreComponents.go 0.00% <0.00%> (ø)
node/chainSimulator/chainSimulator.go 79.41% <76.92%> (+4.41%) ⬆️
...hainSimulator/components/testOnlyProcessingNode.go 0.00% <0.00%> (-6.85%) ⬇️
...de/chainSimulator/components/manualRoundHandler.go 0.00% <0.00%> (ø)
node/chainSimulator/configs/configs.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau merged commit b9252a8 into feat/test-only-processor-node Nov 8, 2023
5 checks passed
@iulianpascalau iulianpascalau deleted the manual-round-handler branch November 8, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants