Fixes for chain simulator #5697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added & called Close on all inner components
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/test-only-processor-node #5697 +/- ##
=================================================================
- Coverage 79.19% 79.05% -0.15%
=================================================================
Files 725 728 +3
Lines 95231 95452 +221
=================================================================
+ Hits 75420 75460 +40
- Misses 14456 14634 +178
- Partials 5355 5358 +3
☔ View full report in Codecov by Sentry. |
miiu96
previously approved these changes
Nov 9, 2023
| @@ -23,6 +23,9 @@ import ( | |||
| "github.com/multiversx/mx-chain-go/testscommon" | |||
| ) | |||
|
|
|||
| var oneEgld = big.NewInt(1000000000000000000) | |||
| var initialStakedEgldPerNode = big.NewInt(0).Mul(oneEgld, big.NewInt(2500)) | |||
| var initialSupply = big.NewInt(0).Mul(oneEgld, big.NewInt(20000000)) // 20 million EGLD | |||
ssd04
reviewed
Nov 9, 2023
Comment on lines
74
to
75
| // AggregateErrors can aggregate all provided error strings into a single error variable | ||
| func AggregateErrors(errorStrings []string) error { |
There was a problem hiding this comment.
AggregateErrors is using global errClose which makes it specific to close errors; rename function? or set errClose as parameter?
There was a problem hiding this comment.
good point. Will refactor 👍
ssd04
approved these changes
Nov 9, 2023
miiu96
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?