Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed return value in the MaxGasPriceSetGuardian method on the disabled fee handler #5703

Merged
merged 2 commits into from Nov 14, 2023

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • bootstrap interceptors threw away SetGuardian transactions

Proposed changes

  • fixed the return value on MaxGasPriceSetGuardian method for the disabled fee handler

Testing procedure

  • standard system test, import-db testing

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

sasurobert
sasurobert previously approved these changes Nov 10, 2023
raduchis
raduchis previously approved these changes Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0101225) 77.61% compared to head (b00ac7a) 77.65%.

❗ Current head b00ac7a differs from pull request most recent head d4da4b9. Consider uploading reports for the commit d4da4b9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5703      +/-   ##
==========================================
+ Coverage   77.61%   77.65%   +0.03%     
==========================================
  Files         656      656              
  Lines       86205    86205              
==========================================
+ Hits        66908    66939      +31     
+ Misses      14091    14059      -32     
- Partials     5206     5207       +1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -49,7 +49,7 @@ func (fh *FeeHandler) ExtraGasLimitGuardedTx() uint64 {

// MaxGasPriceSetGuardian returns 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will take care of that

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: 1.5.14-0101225fc7 -> fix-disabled-fee-handler-d4da4b907a

--- Specific errors ---

block hash does not match 3835
wrong nonce in block 1586
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 2
Nr. of all WARNS: 126
Nr. of new ERRORS: 2
Nr. of new WARNS: 32
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

@iulianpascalau iulianpascalau added the type:bug Something isn't working label Nov 14, 2023
@iulianpascalau iulianpascalau merged commit 1ef37e1 into master Nov 14, 2023
6 checks passed
@iulianpascalau iulianpascalau deleted the fix-disabled-fee-handler branch November 14, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants