Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed forgotten mutexes Unlock calls #5761

Merged
merged 1 commit into from Dec 12, 2023

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • fixed forgotten mutex.Unlock calls

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4c22494) 80.17% compared to head (dd92772) 80.17%.

Files Patch % Lines
process/block/metablock.go 50.00% 1 Missing ⚠️
process/block/shardblock.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.6.0    #5761      +/-   ##
=============================================
- Coverage      80.17%   80.17%   -0.01%     
=============================================
  Files            708      708              
  Lines          94005    94007       +2     
=============================================
  Hits           75370    75370              
- Misses         13291    13293       +2     
  Partials        5344     5344              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ovidiuolteanu ovidiuolteanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning no longer present in static analysis with this fix

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: master-e134e5314d -> fix-forgotten-mutex-unlock-dd92772c4d

--- Specific errors ---

block hash does not match 2573
wrong nonce in block 1088
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 406
Nr. of new ERRORS: 0
Nr. of new WARNS: 4
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@iulianpascalau iulianpascalau merged commit 513a593 into rc/v1.6.0 Dec 12, 2023
8 of 10 checks passed
@iulianpascalau iulianpascalau deleted the fix-forgotten-mutex-unlock branch December 12, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants