Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logger version #5776

Merged
merged 1 commit into from Dec 20, 2023
Merged

New logger version #5776

merged 1 commit into from Dec 20, 2023

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • new logger version

Proposed changes

Testing procedure

  • standard system test
  • start one or more nodes with the log level *:DEBUG,p2p:TRACE, logs containing p2p validator should appear.

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@iulianpascalau iulianpascalau changed the title - new logger version New logger version Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (2dc7af5) 80.37% compared to head (f62255c) 80.33%.
Report is 15 commits behind head on rc/v1.7.0.

Files Patch % Lines
...termui/view/termuic/termuiRenders/widgetsRender.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.7.0    #5776      +/-   ##
=============================================
- Coverage      80.37%   80.33%   -0.04%     
=============================================
  Files            709      709              
  Lines          93990    94018      +28     
=============================================
- Hits           75541    75531      -10     
- Misses         13161    13199      +38     
  Partials        5288     5288              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: master-e134e5314d -> new-logger-2023.12.18-f62255c451

--- Specific errors ---

block hash does not match 1799
wrong nonce in block 690
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 183
Nr. of new ERRORS: 0
Nr. of new WARNS: 7
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

up-mad-validator-25 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 4

up-mad-validator-21 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3

/------/

@iulianpascalau iulianpascalau merged commit 20003ea into rc/v1.7.0 Dec 20, 2023
8 of 10 checks passed
@iulianpascalau iulianpascalau deleted the new-logger-2023.12.18 branch December 20, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants