Non critical fixes for Sirius (patch 2) #5805
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/sirius-patch-2 #5805 +/- ##
==================================================
Coverage 80.14% 80.14%
==================================================
Files 708 708
Lines 94035 94051 +16
==================================================
+ Hits 75365 75381 +16
Misses 13326 13326
Partials 5344 5344 ☔ View full report in Codecov by Sentry. |
storage/factory/dbConfigHandler.go
Outdated
| return err | ||
| } | ||
|
|
||
| isInvalidConfig := len(dbConfig.Type) == 0 || dbConfig.MaxBatchSize <= 0 || dbConfig.BatchDelaySeconds <= 0 |
There was a problem hiding this comment.
check also for MaxOpenFiles ?
vm/systemSmartContracts/esdt.go
Outdated
| message := fmt.Sprintf("%s:%s", specialRoleAddress, roles) | ||
| e.eei.Finish([]byte(message)) | ||
| } | ||
|
|
||
| return vmcommon.Ok | ||
| } | ||
|
|
||
| func (e *esdt) treatErrorForGetSpecialRoles(err error, roles []string, address []byte) { |
There was a problem hiding this comment.
Normal allin test: v1.5.15-dev-config-e134e5314d -> non-critical-fixes-sirius--4790f86f12
--- Specific errors ---
block hash does not match 2236
wrong nonce in block 915
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 200
Nr. of new ERRORS: 0
Nr. of new WARNS: 1
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
do-ams-validator-11 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1
/------/
Reasoning behind the pull request
config.tomlfilesProposed changes
SilentEncodemethod withEncodemethoddbConfigHandlerstruct more robust by always rewriting a given configuration and testing the read configuration from the file so it won't be invalidTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?