Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed comments in prefs.toml #5812

Merged
merged 1 commit into from Jan 8, 2024

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • fixed comments in prefs.toml

Proposed changes

Testing procedure

  • not needed, non production code affected

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d51f756) 80.14% compared to head (d1fe13e) 80.18%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           rc/sirius-patch-2    #5812      +/-   ##
=====================================================
+ Coverage              80.14%   80.18%   +0.04%     
=====================================================
  Files                    708      708              
  Lines                  94034    94034              
=====================================================
+ Hits                   75361    75405      +44     
+ Misses                 13329    13287      -42     
+ Partials                5344     5342       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau merged commit 3d35226 into rc/sirius-patch-2 Jan 8, 2024
10 checks passed
@iulianpascalau iulianpascalau deleted the fix-prefs-toml-comments branch January 8, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants