Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed assessment tool #5820

Merged
merged 1 commit into from Jan 10, 2024
Merged

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • assessment tool was returning errors

Proposed changes

  • changed the contracts to compatible ones

Testing procedure

  • test that the assessment tool does not error anymore

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f524255) 80.14% compared to head (034fb59) 80.14%.
Report is 1 commits behind head on rc/sirius-patch-2.

Additional details and impacted files
@@                Coverage Diff                 @@
##           rc/sirius-patch-2    #5820   +/-   ##
==================================================
  Coverage              80.14%   80.14%           
==================================================
  Files                    708      708           
  Lines                  94051    94051           
==================================================
  Hits                   75381    75381           
  Misses                 13326    13326           
  Partials                5344     5344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau merged commit 8d177e1 into rc/sirius-patch-2 Jan 10, 2024
10 checks passed
@iulianpascalau iulianpascalau deleted the fix-assessment-tool branch January 10, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants