Redundancy metrics updates #5829
Conversation
- added a new metric that contains the reason of step-in, in case the node is not main node and the main node failed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/sirius-patch-2 #5829 +/- ##
=====================================================
+ Coverage 80.15% 80.18% +0.03%
=====================================================
Files 708 708
Lines 94052 94072 +20
=====================================================
+ Hits 75384 75435 +51
+ Misses 13325 13293 -32
- Partials 5343 5344 +1 ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| func (wrk *Worker) computeRedundancyMetrics() (bool, string) { | ||
| if !wrk.nodeRedundancyHandler.IsMainMachineActive() { |
There was a problem hiding this comment.
the nodeRedundancyHandler returns always that the main machine is active for multi-key?
There was a problem hiding this comment.
yes, it does since the key provided/auto-generated in multikey mode is always an observer (otherwise the node can not start). In this setup, the single key redundancy handler does not count "failures" for that key since the key was never part of the consensus.
There was a problem hiding this comment.
--- Specific errors ---
block hash does not match 8848
wrong nonce in block 3530
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 666
Nr. of new ERRORS: 0
Nr. of new WARNS: 2
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
/------/
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?