Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change indexer version #5830

Merged
merged 4 commits into from Jan 16, 2024

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Jan 12, 2024

Reasoning behind the pull request

  • Bug-fix indexer module

Proposed changes

Testing procedure

  • Do a system test and check that in Elasticsearch cluster, there are no transactions with the status field empty

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (daa6651) 80.15% compared to head (7e3c244) 80.15%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           rc/sirius-patch-2    #5830      +/-   ##
=====================================================
- Coverage              80.15%   80.15%   -0.01%     
=====================================================
  Files                    708      708              
  Lines                  94083    94079       -4     
=====================================================
- Hits                   75413    75408       -5     
- Misses                 13326    13328       +2     
+ Partials                5344     5343       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Outdated
@@ -16,7 +16,7 @@ require (
github.com/multiversx/mx-chain-communication-go v1.0.12
github.com/multiversx/mx-chain-core-go v1.2.18
github.com/multiversx/mx-chain-crypto-go v1.2.9
github.com/multiversx/mx-chain-es-indexer-go v1.4.17
github.com/multiversx/mx-chain-es-indexer-go v1.4.18-0.20240112103055-0aaca2e304fe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proper release after testing

gabi-vuls
gabi-vuls previously approved these changes Jan 15, 2024
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: master-ace90ef010 -> upgrade-indexer-version-si-633c9a6595

--- Specific errors ---

block hash does not match 1580
wrong nonce in block 771
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 6
Nr. of all WARNS: 335
Nr. of new ERRORS: 6
Nr. of new WARNS: 25
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

@iulianpascalau iulianpascalau merged commit a7707af into rc/sirius-patch-2 Jan 16, 2024
7 of 8 checks passed
@iulianpascalau iulianpascalau deleted the upgrade-indexer-version-sirius branch January 16, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants