Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rc sirius patch 2023.01.12 #5831

Merged
merged 17 commits into from
Jan 15, 2024

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@iulianpascalau iulianpascalau added the ignore-for-release-notes Do not include item in release notes label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d177e1) 80.14% compared to head (6622473) 80.15%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           rc/sirius-patch-2    #5831   +/-   ##
==================================================
  Coverage              80.14%   80.15%           
==================================================
  Files                    708      708           
  Lines                  94052    94052           
==================================================
+ Hits                   75382    75384    +2     
+ Misses                 13326    13325    -1     
+ Partials                5344     5343    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: master-ace90ef010 -> update-rc-sirius-patch-202-6622473159

--- Specific errors ---

block hash does not match 9731
wrong nonce in block 3644
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 5
Nr. of all WARNS: 7491
Nr. of new ERRORS: 5
Nr. of new WARNS: 77
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

@iulianpascalau iulianpascalau merged commit 29ffc47 into rc/sirius-patch-2 Jan 15, 2024
10 checks passed
@iulianpascalau iulianpascalau deleted the update-rc-sirius-patch-2023.01.12 branch January 15, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants