Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back mutex protection #5833

Merged
merged 1 commit into from Jan 15, 2024
Merged

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • put back mutex protection

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ace90ef) 80.18% compared to head (103c36c) 80.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5833      +/-   ##
==========================================
- Coverage   80.18%   80.14%   -0.04%     
==========================================
  Files         708      708              
  Lines       94035    94039       +4     
==========================================
- Hits        75398    75371      -27     
- Misses      13293    13325      +32     
+ Partials     5344     5343       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: master-ace90ef010 -> revert-mutex-calls-in-trie-103c36cf09

--- Specific errors ---

block hash does not match 7410
wrong nonce in block 3184
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 639
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@iulianpascalau iulianpascalau merged commit 0876737 into master Jan 15, 2024
9 of 10 checks passed
@iulianpascalau iulianpascalau deleted the revert-mutex-calls-in-trie branch January 15, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants