Fixed wrong multikey backup machine step-in #5840
Conversation
…at commit block time.
| @@ -593,5 +593,5 @@ var ErrEmptyAddress = errors.New("empty Address") | |||
| // ErrInvalidNodeOperationMode signals that an invalid node operation mode has been provided | |||
| var ErrInvalidNodeOperationMode = errors.New("invalid node operation mode") | |||
|
|
|||
| // ErrNilTxExecutionOrderHandler signals that a nil tx execution order handler has been provided | |||
| var ErrNilTxExecutionOrderHandler = errors.New("nil tx execution order handler") | |||
There was a problem hiding this comment.
ErrNilTxExecutionOrderHandler was unused
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## rc/sirius-patch-2 #5840 +/- ##
==================================================
Coverage 80.19% 80.19%
==================================================
Files 708 709 +1
Lines 94094 94128 +34
==================================================
+ Hits 75454 75484 +30
- Misses 13295 13297 +2
- Partials 5345 5347 +2 ☔ View full report in Codecov by Sentry. |
| ) | ||
|
|
||
| // ComputeConsensusGroup will compute the consensus group that assembled the provided block | ||
| func ComputeConsensusGroup(header data.HeaderHandler, nodesCoordinator nodesCoordinator.NodesCoordinator) (validatorsGroup []nodesCoordinator.Validator, err error) { |
There was a problem hiding this comment.
missing nil checks on parameters
process/block/baseProcess.go
Outdated
| validatorsPKs = append(validatorsPKs, validator.PubKey()) | ||
| } | ||
|
|
||
| bp.sentSignaturesTracker.ResetCountersManagedBlockSigners(validatorsPKs) |
There was a problem hiding this comment.
perhaps ResetCountersManagedBlockSigner, thus no need for second iteration on sentSignaturesTracker component?
There was a problem hiding this comment.
interesting. Yes, I think we can refactor this to gain performance. Thanks
| @@ -80,7 +81,7 @@ func checkNewFactoryParams( | |||
| return spos.ErrNilAppStatusHandler | |||
| } | |||
| if check.IfNil(sentSignaturesTracker) { | |||
| return spos.ErrNilSentSignatureTracker | |||
| return errors.ErrNilSentSignatureTracker | |||
There was a problem hiding this comment.
any reason to use the error in errors package?
it adds a new package dependency
iulianpascalau
dismissed stale reviews from AdoAdoAdo and sstanculeanu
via
2bc1c58
There was a problem hiding this comment.
Normal allin test: master-06f147d698 -> fix-wrong-backup-step-in-2bc1c58b8d
--- Specific errors ---
block hash does not match 9766
wrong nonce in block 3351
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 18
Nr. of all WARNS: 6595
Nr. of new ERRORS: 18
Nr. of new WARNS: 75
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?